Messages in this thread | | | Date | Fri, 9 Mar 2007 11:34:15 -0500 | From | Josef Sipek <> | Subject | Re: [PATCH 1/2] eCryptfs: convert lookup_one_len() to lookup_one_len_nd() |
| |
On Fri, Mar 09, 2007 at 09:40:00AM +0000, Christoph Hellwig wrote: > On Sat, Feb 17, 2007 at 03:56:55AM -0500, Josef 'Jeff' Sipek wrote: > > From: Michael Halcrow <mhalcrow@us.ibm.com> > > > > Call the new lookup_one_len_nd() rather than lookup_one_len(). This fixes an > > oops when stacked on NFS. > > > > Note that there are still some issues with eCryptfs on NFS having to do with > > directory deletion (I'm not getting an oops, just an -EBUSY). > > Biug NACK here. This is just working around the broken lookup intents > code. lookup_one_len still is a hack for some network filesystems that > unfortunately grew a few too many users. I'm working on the 4-th case to do_path_lookup. The only problem left, is the negative dentries. do_path_lookup returns -ENOENT. Which would means that we need either a wrapper that returns the negative dentry instead of > Implementing this might be a good idea anyway to clean up the mess > do_path_lookup is currently.
Clean up? There are 4 (including the new case) "setup" cases, and then the actual lookup happens. You'll need the crazy if conditions unless the mening of the arguments changes.
Josef "Jeff" Sipek.
-- UNIX is user-friendly ... it's just selective about who it's friends are - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |