lkml.org 
[lkml]   [2007]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address
Hi!

> > > Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
> >
> > > +static int swsusp_header_init(void)
> > > +{
> > > + swsusp_header = (struct swsusp_header*) __get_free_page(GFP_KERNEL);
> > > + if (!swsusp_header)
> > > + panic("Could not allocate memory for swsusp_header\n");
> > > + return 0;
> > > +}
> > > +
> > > +core_initcall(swsusp_header_init);
> >
> > I do not like the panic, but I guess it is okay as we are running
> > during boot? (Could you add a comment?) Otherwise ok.
> >
>
> Hi Pavel,
>
> Yes, it is an initcall and this memory page will be allocated during
> boot time. Not very sure what comment to put there. To me it seems
> pretty obivious with "core_initcall".

I'd put "/* running at boot time, so allocation can't fail */" there
(and maybe just replace panic with BUG_ON), but I guess that's not
important.

ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-08 12:51    [W:0.062 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site