Messages in this thread | | | Date | Wed, 07 Mar 2007 10:42:57 -0500 | From | Mark Lord <> | Subject | Re: [PATCH] prism54usb: Fix hail of warnings on 64bit platforms |
| |
Alan Cox wrote: > If you want to cast a pointer to a small value then start by turning it > into an unsigned long so the compiler knows what is going on. > > Personally I find the whole approach used by this driver for types of > registers (which are really USB register numbers) utterly perverse... ... > > err = p54u_write(priv, buf, type,\ > - cpu_to_le32((u32)addr), data);\ > + cpu_to_le32((u32)(unsigned long)addr), data);\ ...
What exactly are those "addr" parameters -- memory addresses ?
-ml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |