Messages in this thread | | | Subject | RE: [PATCH] xfrm_policy delete security check misplaced | From | Eric Paris <> | Date | Mon, 05 Mar 2007 11:51:28 -0500 |
| |
On Mon, 2007-03-05 at 11:39 -0500, James Morris wrote: > On Mon, 5 Mar 2007, Venkat Yekkirala wrote: > > > > > > > Signed-off-by: Eric Paris <eparis@redhat.com> > > Acked-by: Venkat Yekkirala <vyekkirala@trustedcs.com> > > What about your previous comment: > > "I guess you meant to do this here? > else if (err) > return err; "
That also gets taken care of in the pfkey_spdget cleanup in a later patch. The return isn't in that same place venkat suggested it instead happens inside the new if (delete) block. (err is only non-zero on delete operations so there is no need to check it otherwise)
-Eric
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |