Messages in this thread | | | Date | Sat, 03 Mar 2007 15:28:48 -0500 | From | Bill Davidsen <> | Subject | Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2) |
| |
Alan Cox wrote: >> it seems broken to manipulate xfer_mask after returning from the >> driver's ->mode_filter hook. >> >> this patch is more than just a speed-limited warning printk, afaics > > I actually suggested that order because the only way the printk can be > done correctly is for it to be the very last test made. Since the mode > filter is not told what mode will be used but just subtracts modes that > are not allowed this should be safe.
Far better to have a drive which works slowly than one which works unreliably.
-- Bill Davidsen <davidsen@tmr.com> "We have more to fear from the bungling of the incompetent than from the machinations of the wicked." - from Slashdot - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |