Messages in this thread Patch in this message | | | Date | Tue, 27 Mar 2007 10:54:25 +0200 | Subject | Re: [PATCH] IRQ: Check for PERCPU flag only when adding first irqaction. | From | "Ahmed S. Darwish" <> |
| |
On Mon, Mar 26, 2007 at 09:14:55PM +0200, ahmed wrote: > Hi, > > An irqaction structure won't be added to the IRQ line irqaction list if they > don't agree wrt the IRQF_PERCPU flag. Only check and set this flag in IRQ > descriptor `status' field when the first irqaction is added to the line list. > > > Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com> > --- > Patch over 2.6.21-rc5.
Maybe just a better description (with the same patch below):
An irqaction structure won't be added to an IRQ descriptor irqaction list if it don't agree with other irqactions on the IRQF_PERCPU flag. Don't check for this flag to change IRQ descriptor `status' for every irqaction added to the list, Doing the check only for the first irqaction added is enough.
Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com> --- diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 5597c15..ea82a54 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -317,10 +317,7 @@ int setup_irq(unsigned int irq, struct irqaction *new) } *p = new; -#if defined(CONFIG_IRQ_PER_CPU) - if (new->flags & IRQF_PERCPU) - desc->status |= IRQ_PER_CPU; -#endif + /* Exclude IRQ from balancing */ if (new->flags & IRQF_NOBALANCING) desc->status |= IRQ_NO_BALANCING; @@ -328,6 +325,11 @@ int setup_irq(unsigned int irq, struct irqaction *new) if (!shared) { irq_chip_set_defaults(desc->chip); +#if defined(CONFIG_IRQ_PER_CPU) + if (new->flags & IRQF_PERCPU) + desc->status |= IRQ_PER_CPU; +#endif + /* Setup the type (level, edge polarity) if configured: */ if (new->flags & IRQF_TRIGGER_MASK) { if (desc->chip && desc->chip->set_type)
-- Ahmed S. Darwish http://darwish.07.googlepages.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |