Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH -mm] Blackfin arch: add kdebug header file | Date | Mon, 26 Mar 2007 23:45:08 +0200 |
| |
I can see nothing wrong with your patches, but you should make the patch descriptions a little clearer:
On Monday 26 March 2007, Wu, Bryan wrote: > Hi folks,
No need for this line, if it's there, Andrew just needs to remove it from the changelog.
> This patch adds kdebug.h header file to blackfin architecture.
This line is completely redundant, as it states the same information as the subject. You should give some background information here, like:
kdebug.h is needed for kprobes.
For trivial patches where the subject already tells the whole story (e.g. 'remove redundant declaration of foo'), just leave out the description entirely except for the Signed-off-by.
Arnd <>< you can even leave out the description - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |