Messages in this thread | | | Date | Mon, 26 Mar 2007 12:24:06 -0800 | From | Zachary Amsden <> | Subject | Re: [patch -mm] i386: use pte_update_defer in ptep_test_and_clear_{dirty,young} |
| |
David Rientjes wrote: > Date: Sun, 25 Mar 2007 23:07:43 -0800 > From: Zachary Amsden <zach@vmware.com> > > If you actually clear the bit, you need to: > > + pte_update_defer(vma->vm_mm, addr, ptep); > > The reason is, when updating PTEs, the hypervisor must be notified. Using > atomic operations to do this is fine for all hypervisors I am aware of. > However, for hypervisors which shadow page tables, if these PTE > modifications are not trapped, you need a post-modification call to fulfill > the update of the shadow page table. > > Cc: Zachary Amsden <zach@vmware.com> > Cc: Hugh Dickins <hugh@veritas.com> > Signed-off-by: David Rientjes <rientjes@google.com> >
Acked-by: Zachary Amsden <zach@vmware.com>
David, thanks for cleaning this up. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |