lkml.org 
[lkml]   [2007]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable
Andi Kleen wrote:
> One thing I was pondering was to replace the expensive popfs with
>
> bt $IF,(%rsp)
> jnc 1f
> sti
> 1:
>
> But would be mostly a P4 optimization again and I'm not 100% sure it is
> worth it.
>

Worth it on 32-bit. On AMD64, probably not. On Intel 64-bit, maybe,
but less important than in P4 days.

This could change character completely if used at the tail of a function
where you now have

sti; 1: ret

Which generates an interrupt holdoff on the ret, an unusual thing to do.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-20 20:58    [W:0.223 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site