lkml.org 
[lkml]   [2007]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable


    On Tue, 20 Mar 2007, Andi Kleen wrote:
    >
    > The code never did that. In fact many of the problems we had initially
    > especially came out of that -- the fallback code that would handle
    > this case wasn't fully correct.

    I don't keep my emails any more, but you *never* fixed the problems in
    arch/*/kernel/traps.c.

    Yes, the kernel/unwind.c issues generally got fixed. The infinite loops in
    the *callers* never did.

    > Also frankly often your analysis about what went wrong was just
    > incorrect.

    Still in denial, I see.

    Do you still claim that "the fallback position always did the right
    thing"? Despite the fact that the unwinder had sometimes *corrupted* the
    incoming information so much that the fallback position was the one that
    oopsed? And no, you didn't fix that.

    And no, IT DID NOT use probe_kernel_address like you still claim.

    Anyway, you work for Suse, I don't care what you do to the Suse kernel.
    Maybe it will get stable some day. Somehow, I doubt it.

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-20 18:31    [W:2.335 / U:0.776 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site