lkml.org 
[lkml]   [2007]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data
Dale Farnsworth wrote:
> We were using the platform_device.id field to identify which ethernet
> port is used for mv643xx_eth device. This is not generally correct.
> It will be incorrect, for example, if a hardware platform uses a single
> port but not the first port. Here, we add an explicit port_number field
> to struct mv643xx_eth_platform_data.
>
> This makes the mv643xx_eth_platform_data structure required, but that
> isn't an issue since all users currently provide it already.
>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
>
> ---
>
> arch/mips/momentum/jaguar_atx/platform.c | 8 ++
> arch/mips/momentum/ocelot_3/platform.c | 8 ++
> arch/mips/momentum/ocelot_c/platform.c | 4 +
> arch/powerpc/platforms/chrp/pegasos_eth.c | 2
> arch/ppc/syslib/mv64x60.c | 12 +++-
> drivers/net/mv643xx_eth.c | 59 ++++++++++----------
> include/linux/mv643xx.h | 1
> 7 files changed, 62 insertions(+), 32 deletions(-)

ACK but not applied, patch corrupted


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-03 02:21    [W:0.048 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site