lkml.org 
[lkml]   [2007]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Sanitize filesystem NLS handling
From
Date
"Alexander E. Patrakov" <patrakov@ums.usu.ru> writes:

> * Removes CONFIG_FAT_DEFAULT_IOCHARSET, now CONFIG_NLS_DEFAULT is used
> for this purpose. This is because the correct setting of both must match
> the user's locale

The some filesystems want to use utf-8, and others don't want to use
utf-8, no? And is it also true about some devices using vfat?

> * Merges the two CONFIG_SMB_NLS_REMOTE and CONFIG_FAT_DEFAULT_CODEPAGE
> options into one, named CONFIG_CODEPAGE_DEFAULT. This is because the
> correct setting of both must match the code page used by MS-DOS in the
> user's country. For the same reason, CONFIG_SMB_NLS_DEFAULT is removed
> (the only sane choice is "y")

No. Unfortunately the real is not simple like it in some case.

> * Makes the FAT filesystem accept both the old-style "codepage=866"
> mount option (which is inconsistent with other filesystems requiring a
> codepage option) and the new-style "codepage=cp866" option. This is
> necessary because CONFIG_CODEPAGE_DEFAULT must work for all filesystems
> that use it

You allow to set any nls to codepage? If so, it is not good.

> * Downgrades the UTF-8 FAT warning to a note, because, while using the
> utf8 iocharset produces a case-sensitive FAT filesystem, other
> iocharsets simply produce wrong characters, which is much worse

No, utf-8 makes completely wrong entry. It's more wrong than other nls.

> * Makes CONFIG_NLS_DEFAULT and CONFIG_CODEPAGE_DEFAULT adjustable at
> runtime via the following mechanisms:

The configurable sounds sane, and it may help some case. But, it should
not be system global. At least, I think the default would be per-filesystem,
otherwise some configs seems to be needed for other filesystem after all.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-18 23:05    [W:0.074 / U:1.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site