Messages in this thread | | | Date | Fri, 16 Mar 2007 09:32:52 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] i386: Simplify smp_call_function*() by using common implementation |
| |
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Subject: Simplify smp_call_function*() by using common implementation > > smp_call_function and smp_call_function_single are almost complete > duplicates of the same logic. This patch combines them by > implementing them in terms of the more general > smp_call_function_mask().
> + /* Send a message to other CPUs */ > + if (cpus_equal(mask, allbutself)) > + send_IPI_allbutself(CALL_FUNCTION_VECTOR); > + else > + send_IPI_mask(mask, CALL_FUNCTION_VECTOR);
this is a bit ugly, but i guess we cannot do much about it - the hardware side handles this in a bit assymetric way too.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |