lkml.org 
[lkml]   [2007]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

    * Jeremy Fitzhardinge <jeremy@goop.org> wrote:

    > This patch introduces paravirt_ops hooks to control how the kernel's
    > initial pagetable is set up.

    looks good. Some minor nits:

    > + /* Make sure kernel address space is empty so that a pagetable
    > + will be allocated for it. */

    comment style.

    > + /* Enable PSE if available */
    > + if (cpu_has_pse) {
    > + set_in_cr4(X86_CR4_PSE);
    > + }

    unnecessary braces.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-16 10:37    [W:2.786 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site