Messages in this thread | | | Date | Wed, 14 Mar 2007 20:02:54 +0100 | From | Vojtech Pavlik <> | Subject | Re: [PATCH 0/2] wistron_btns: More keymaps |
| |
On Wed, Mar 14, 2007 at 02:58:49PM -0400, Dmitry Torokhov wrote:
> >> I have couple of comments/requests: > >> > >> 1. KEY_OPEN and KEY_CLOSE should not be used to signal state of the > >> lid, they correspond to Accpication Control Open and Close keys from > >> USB HID HUT spec: > >> > >> http://www.usb.org/developers/devclass_docs/Hut1_12.pdf > >> > >> SW_LID shoudl be used to signal lid state instead. > >> > >> 2. I also have a concern about using KEY_SCREEN to signal toggling > >> display on and off. I am CCing Vojtech - he must know what the > >> original intent of this key code was. BTW, when user presses > >> corresponding button - does the display actually goes off? Maybe we > >> need another switch. > > > >Sorry, Dmitry, I probably should have documented it back then, I don't > >have the slightest idea anymore. > > > > That's what I was afraid of ;) Well, maybe we should just use it to > indicate display switch and add a comment to that effect to input.h...
Digging somewhat deeper into my memory, I think it just so happened that there was a keyboard with a key with a pictogram of a computer screen on it with no really defined purpose. Since at that time there was only a limited number of different extended keyboard types, it was added.
I think it'd make sense to use it eg. for the key that switches between internal and external output on laptops, if the laptop generates a keycode for the key at all. But maybe that function is already taken by KEY_SWITCHVIDEOMODE ...
-- Vojtech Pavlik Director SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |