Messages in this thread | | | Date | Wed, 14 Mar 2007 12:48:30 +0200 | From | "Alexey Dobriyan" <> | Subject | Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support |
| |
On 3/14/07, Ingo Molnar <mingo@elte.hu> wrote: > #define PROCNAME_PML "sys/kernel/preempt_max_latency" > > static __init int latency_fs_init(void) > { > struct proc_dir_entry *entry; > > if (!(entry = create_proc_entry(PROCNAME_PML, 0644, NULL))) > printk("latency_fs_init(): can't create %s\n", > PROCNAME_PML); > > with your change that broke because beyond /proc/sys/ there are no real > proc entries anymore, there's no de->subdir directory for > xlate_proc_name() to find. While the latency tracer isnt upstream, this > change in semantics does not seem to be intended (the changelog is > certainly silent about it).
Use register_sysctl_table() for sysctls. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |