Messages in this thread | | | Date | Mon, 12 Mar 2007 12:45:48 +0200 | Subject | Re: [PATCH] drivers/media/video/videocodec.c: check kmalloc() return value. | From | "Ahmed S. Darwish" <> |
| |
Hi Amit,
On Thu, Mar 08, 2007 at 11:14:01PM -0800, Amit Choudhary wrote: > Description: Check the return value of kmalloc() in function > videocodec_build_table(), in file drivers/media/video/videocodec.c.
No need for `Description:'. This line is automatically put in the logs as a patch description if the patch got accepted.
It's better not to use very large lines.
Also there's no need to specify the exact function in the log, it's already displayed in the patch.
> > Signed-off-by: Amit Choudhary <amit2030@gmail.com> >
As said in Documentation/SubmittingPatches put a "---" line after Signed-off-by signature.
Thanks,
-- Ahmed S. Darwish http://darwish.07.googlepages.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |