lkml.org 
[lkml]   [2007]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)
From
Date
Hi Trent,

Patch looks good, just one comment:

On Mon, 2007-03-12 at 07:07 -0700, Trent Piepho wrote:
> + use = already_uses(a, b);
> + if (!use) {
> + printk(KERN_ERR "module %s trying to un-use a module, %s, which "
> + "it is not using", a->name, b->name);
> + return 0;
> + }

s/return 0/BUG()/. This is potentially quite a nasty bug.

Thanks!
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-03-12 23:17    [W:0.944 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site