Messages in this thread | | | Subject | Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put) | From | Rusty Russell <> | Date | Tue, 13 Mar 2007 09:13:00 +1100 |
| |
Hi Trent,
Patch looks good, just one comment:
On Mon, 2007-03-12 at 07:07 -0700, Trent Piepho wrote: > + use = already_uses(a, b); > + if (!use) { > + printk(KERN_ERR "module %s trying to un-use a module, %s, which " > + "it is not using", a->name, b->name); > + return 0; > + }
s/return 0/BUG()/. This is potentially quite a nasty bug.
Thanks! Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |