lkml.org 
[lkml]   [2007]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [discuss] [PATCH 4/4 TRY#3] optimize and simplify get_cycles_sync()
    Hi Joerg,

    On Mon, 12 Mar 2007, Joerg Roedel wrote:

    > > >+#define RDTSCP ".byte 0x0f, 0x01, 0xf9"
    > > >+ alternative_io_two("cpuid\nrdtsc",
    > > >+ "rdtsc", X86_FEATURE_SYNC_RDTSC,
    > > >+ ".byte 0x0f, 0x01, 0xf9", X86_FEATURE_RDTSCP,
    > > >
    > >
    > > why not use the RDTSCP macro here?
    >
    > Does this macro exist?

    Look carefully at your patch again, or at least the four quoted lines
    above. You've added it yourself, in exactly the form you'd need in the
    alternative_io_two() call :-)

    > I couldn't found it in the current git tree. And the rdtscp macros in
    > msr.h use the plain opcode too.


    Ciao,
    Michael.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-12 14:33    [W:7.768 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site