lkml.org 
[lkml]   [2007]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4 of 7] lguest: Config and headers
On Sat, 10 Feb 2007, Rusty Russell wrote:

> +/* 64k ought to be enough for anybody! */
> +#define HYPERVISOR_MAP_ORDER 16
> +#define HYPERVISOR_PAGES ((1 << HYPERVISOR_MAP_ORDER)/PAGE_SIZE)

I think it'd be better to go back to defining HYPERVISOR_SIZE then derive
the map order from that via get_order(), as it should be 4 instead of 16;
and this code is now both implying PAGE_SIZE while also using it for
calculations.


- James
--
James Morris
<jmorris@namei.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-09 19:19    [W:0.283 / U:1.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site