Messages in this thread | | | Date | Fri, 9 Feb 2007 02:46:26 +0100 | From | Nick Piggin <> | Subject | Re: [patch 1/3] fs: add an iovec iterator |
| |
On Thu, Feb 08, 2007 at 07:49:53PM +0000, Christoph Hellwig wrote: > On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote: > > Add an iterator data structure to operate over an iovec. Add usercopy > > operators needed by generic_file_buffered_write, and convert that function > > over. > > iovec_iterator is an awfully long and not very descriptive name. > In past discussions we named this thingy iodesc and wanted to pass it > down all the I/O path, including the file operations.
Hi Christoph,
Sure I think it would be a good idea to shorten the name. And yes, although I just construct the iterator to pass into perform_write, I think it should make sense to go much further up the call stack instead of passing all those args around. iodesc seems like a fine name, so I'll use that unless anyone objects.
Thanks, Nick - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |