Messages in this thread | | | Date | Thu, 08 Feb 2007 17:20:50 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] Use correct macros in raid code, not raw asm |
| |
Andi Kleen wrote: >> The code looks like it's designed to be included from userspace for >> testing; as it compiles without this include (and has no other >> includes), I chose not to add it. >> >> Linus makes a good point, but someone who actually knows the code >> should, y'know, test it and stuff... > > It should use kernel_fpu_begin() imho. If someone wants to test > it in user space again they can add dummy definitions of that > to their user space header.
I hadn't seen this thread until now, when Neil pointed me to the thread.
Using kernel_fpu_begin() ... kernel_fpu_end() is probably indeed the best option.
-hpa
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |