lkml.org 
[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] refix localversion handling
From
On Thu, Feb 08, 2007 at 01:13:39AM +0100, Roman Zippel wrote:
> Hi,
>
> This reverts part of the localversion patch, which now already got into
> git. It removes the unnecessary find call, with the simpler $(notdir ...)
> fix.

I'm certainly have more stuff to deal with, but that was my attept to
prevent bloatware in makefiles (unlucky "meat" from "flies" split ;)

>
> -pattern = ".*/localversion[^~]*"
> -string = $(shell cat /dev/null \
> - `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`)
> -
> -localver = $(subst $(space),, $(string) \
> - $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
> +___localver = $(objtree)/localversion* $(srctree)/localversion*
> +__localver = $(sort $(wildcard $(___localver)))
> +# skip files containing '~' (like backup files)
> +_localver = $(foreach f,$(__localver),$(if $(findstring ~,$(notdir $(f))),,$(f)))
> +
> +localver = $(subst $(space),, \
> + $(shell cat /dev/null $(_localver)) \
> + $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
____
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-08 01:25    [W:0.069 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site