Messages in this thread | | | Date | Wed, 7 Feb 2007 19:03:24 +0100 | Subject | Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files | From | Oleg Verych <> |
| |
On Wed, Feb 07, 2007 at 03:39:38PM +0100, Roman Zippel wrote: > Hi, > > On Tue, 6 Feb 2007, Oleg Verych wrote: > > > -nullstring := > > -space := $(nullstring) # end of line > > +pattern = ".*/localversion[^~]*" > > +string = $(shell cat /dev/null \ > > + `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`) > > Calling find here is overkill, if the same can be done with standard make > functions. I very much prefer to just add the damn $(notdir ...) and be > done with it.
Yes? I whould insist on it as separation of "meat" from "flies", i.e paths from files, instead of (ugly) reparsing. But you know better.
Thanks.
____ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |