lkml.org 
[lkml]   [2007]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Re: Bio device too big | kernel BUG at mm/filemap.c:537!
On Wed, 7 Feb 2007 10:26:56 +1100
Neil Brown <neilb@suse.de> wrote:

> +static int bio_fits_rdev(struct bio *bi)
> +{
> + request_queue_t *q = bdev_get_queue(bi->bi_bdev);
> +
> + if ((bi->bi_size>>9) > q->max_sectors)
> + return 0;
> + blk_recount_segments(q, bi);
> + if (bi->bi_phys_segments > q->max_phys_segments ||
> + bi->bi_hw_segments > q->max_hw_segments)
> + return 0;
> +
> + if (q->merge_bvec_fn)
> + /* it's too hard to apply the merge_bvec_fn at this stage,
> + * just just give up
> + */
> + return 0;
> +
> + return 1;
> +}

Isn't think going to return 0 rather a lot of the time?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-07 02:19    [W:0.909 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site