lkml.org 
[lkml]   [2007]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: 2.6.20-rc7: known regressions
    From
    Date
    Le samedi 03 février 2007 à 11:57 +0100, Frédéric Riss a écrit :
    > Le samedi 03 février 2007 à 11:51 +0100, Andi Kleen a écrit :
    > > > +
    > > > +typedef efilinkage efi_status_t efi_get_time_t (efi_time_t *tm,
    > > > + efi_time_cap_t *tc);
    > >
    > > I assume you have double checked it actually works? (i vaguely recall some
    > > issues with applying attributes to typedefs). If not you would need
    > > to put them to the declarations.
    >
    > Of course, I tested 10 suspend/resume cycles. This is with gcc 4.1.2, I
    > guess other compilers could mishandle it. Would you prefer the version
    > putting asmlinkage inside the struct definition?

    But then it then throws 'assignment from incompatible pointer type'
    warnings in efi.c. This would need fixing in arch/ia64 and arch/i386. Or
    should I put it in the typdefs _and_ in the struct to be safe ?

    Fred

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-03 12:11    [W:4.972 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site