Messages in this thread | | | Date | Wed, 28 Feb 2007 09:34:12 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2 |
| |
On Wed, 28 Feb 2007, Jiri Kosina wrote: > > You're right that usbhid.h is not a best place for it.
"Not the best place for it" is the understatement of the year.
It's totally idiotic.
> This IMHO just needs cleanup. Will you accept creating a separate header > file solely for purposes of this blacklist and related defines?
*NO*.
Dammit, we don't put static initializers in header files. We don't duplicate the data in every single thing that includes a header file. If you want to duplicate the data, you export it as a real data structure, and you *still* put the data structure in a .c file.
> Otherwise I will just drop this cleanup, but I still think that the > current situation is horrible.
WHAT CLEANUP? The thing is the anti-thesis of a "cleanup". There is no excuse for putting a large array in a header file and including it millions of times. Or even just twice. The point of a header file is to *declare* things, not to have big data structures in.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |