Messages in this thread Patch in this message | | | Date | Tue, 27 Feb 2007 12:25:21 +0100 | From | Ingo Molnar <> | Subject | Re: regression: forcedeth.c hang |
| |
update: Jeff sent me 3 pending forcedeth.c fixes, and they indeed fix the regression. The one that fixed it is:
-----------------> The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path.
Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia.com>
--- orig/drivers/net/forcedeth.c 2007-02-20 03:17:21.000000000 -0500 +++ new/drivers/net/forcedeth.c 2007-02-20 03:28:31.000000000 -0500 @@ -3104,13 +3104,17 @@ struct fe_priv *np = netdev_priv(dev); u8 __iomem *base = get_hwbase(dev); unsigned long flags; + int retcode; - if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) + if (np->desc_ver == DESC_VER_1 || np->desc_ver == DESC_VER_2) { pkts = nv_rx_process(dev, limit); - else + retcode = nv_alloc_rx(dev); + } else { pkts = nv_rx_process_optimized(dev, limit); + retcode = nv_alloc_rx_optimized(dev); + } - if (nv_alloc_rx(dev)) { + if (retcode) { spin_lock_irqsave(&np->lock, flags); if (!np->in_shutdown) mod_timer(&np->oom_kick, jiffies + OOM_REFILL); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |