lkml.org 
[lkml]   [2007]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 7/7] Freezer: Add try_to_freeze calls to all kernel threads
    Hi!

    > Add try_to_freeze() calls to the remaining kernel threads that do not call
    > try_to_freeze() already, although they set PF_NOFREEZE.
    >
    > In the future we are going to replace PF_NOFREEZE with a set of flags that will
    > be set to indicate in which situations the task should not be frozen (for
    > example, there can be a task that should be frozen for the CPU hotplugging and
    > should not be frozen for the system suspend). For this reason every kernel
    > thread should be able to freeze itself (ie. call try_to_freeze()), so that it
    > can be frozen whenever necessary.
    >
    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

    Looks ok to me. ACK.

    > @@ -113,6 +114,8 @@ static int mtd_blktrans_thread(void *arg
    > schedule();
    > remove_wait_queue(&tr->blkcore_priv->thread_wq, &wait);
    >
    > + try_to_freeze();
    > +
    > spin_lock_irq(rq->queue_lock);
    >
    > continue;

    I'd prefer to move try_to_freeze() just after schedule().
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-25 11:49    [W:4.105 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site