Messages in this thread | | | Date | Fri, 23 Feb 2007 13:15:10 +0100 | From | Helge Hafting <> | Subject | Re: [PATCH 006 of 6] md: Add support for reshape of a raid6 |
| |
Andrew Morton wrote: > On Thu, 22 Feb 2007 13:39:56 +1100 Neil Brown <neilb@suse.de> wrote: > > >> I must right code that Andrew can read. >> > > That's write. > > But more importantly, things that people can immediately see and understand > help reduce the possibility of mistakes. Now and in the future. > > If we did all loops like that, then it'd be the the best way to do it in new code, > because people's eyes and brains are locked into that idiom and we just > don't have to think about it when we see it. I have done lots of loops like that and understood it immediately. Nice, short, _clear_ and no - a loop that counts down instead of up is not difficult at all. Testing "i--" instead of "i >= 0" is also something I consider trivial, even though I don't code that much. If this is among the worst you see, then the kernel source must be in great shape ;-)
Helge Hafting - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |