Messages in this thread | | | Date | Wed, 21 Feb 2007 19:17:59 -0800 | From | Andrew Morton <> | Subject | Re: [Patch 2/2] cciss: add reboot notifier support to driver |
| |
On Wed, 21 Feb 2007 15:12:51 -0600 "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> wrote:
> @@ -3293,6 +3327,12 @@ #endif > ((hba[i]->nr_cmds + BITS_PER_LONG - > 1) / BITS_PER_LONG) * sizeof(unsigned long)); > > + if (notify_count == 0) { > + register_reboot_notifier(&cciss_notifier); > + notify_count=1; > + } > + > + > #ifdef CCISS_DEBUG > printk(KERN_DEBUG "Scanning for drives on controller cciss%d\n", i); > #endif /* CCISS_DEBUG */ > @@ -3500,6 +3540,7 @@ static void __exit cciss_cleanup(void) > int i; > > pci_unregister_driver(&cciss_pci_driver); > + unregister_reboot_notifier(&cciss_notifier);
Should we check that it was registered before going and unregistering it? ie: do `modprobe cciss' on a machine which has no cciss hardware, then do rmmod... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |