Messages in this thread | | | Subject | Re: [PATCH 03/44 take 2] [UBI] user-space API header | From | Artem Bityutskiy <> | Date | Tue, 20 Feb 2007 15:07:13 +0200 |
| |
On Sat, 2007-02-17 at 22:27 +0100, Arnd Bergmann wrote: > On Saturday 17 February 2007 17:54, Artem Bityutskiy wrote: > > +struct ubi_mkvol_req { > > + int32_t vol_id; > > + int32_t alignment; > > + int64_t bytes; > > + int8_t vol_type; > > + int8_t padding[9]; > > + int16_t name_len; > > + __user const char *name; > > +} __attribute__ ((packed)); > > This structure is not suitable for an ioctl call, because it has > incompatible layout between 32 and 64 bit processes. The easiest > fix for this would be to change the 'name' field to an array > instead of a pointer.
Will be fixed thanks. Just out of curiosity, could you please provide an example when this may be a problem.
Artem.
-- Best regards, Artem Bityutskiy (Битюцкий Артём)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |