Messages in this thread | | | Date | Tue, 20 Feb 2007 14:31:19 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH] free swap space when (re)activating page |
| |
Christoph Lameter wrote: > On Tue, 20 Feb 2007, Rik van Riel wrote: > >> Nono, I try to remove the swap space occupied by pages that >> go back onto the active list. Regardless of whether they >> were already there, or whether they started out on the >> inactive list. > > Ok then do it for all pages that go back not just for those leftover from > the moving of pages to the inactive list (why would you move those???)
I do. The only pages that are exempt are the pages that move from the active list to the inactive list, because those will probably be evicted soon enough.
> Maybe the hunk does apply in a different location than I thought.
I suspect that's the case ...
> If you > do that in the loop over the pages on active list then it would make > sense. But in that case you need another piece of it doing the same to the > pages that are released at the end of shrink_active_list().
... because I think this is what my patch does :)
-- All Rights Reversed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |