Messages in this thread | | | Date | Tue, 20 Feb 2007 08:28:52 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH] free swap space when (re)activating page |
| |
Christoph Lameter wrote: > On Fri, 16 Feb 2007, Rik van Riel wrote: > >> What do you think? > > Looks good apart from one passage (which just vanished when I tried to > reply, please post patches as inline text). > > It was the portion that modifies shrink_active_list. Why operate > on the pagevec there? The pagevec only contains the leftovers to be > released from scanning over the temporary inactive list.
Why? Because the pages that were not referenced will be going onto the inactive list and are now a candidate for swapping out. I don't see why we would want to reclaim the swap space for pages that area about to be swapped out again.
-- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |