Messages in this thread | | | Date | Fri, 02 Feb 2007 12:10:17 +0100 | From | Jan Dittmer <> | Subject | Re: [PATCH] lirc: remove backwards compatibility macro obfuscation (Was: Free Linux Driver Development!) |
| |
Pekka J Enberg wrote: > From: Pekka Enberg <penberg@cs.helsinki.fi> > > On 02 Feb 2007 05:54:00 +0100, Christoph Bartelmus <lirc@bartelmus.de> wrote: >> I just made clear that I don't have the time to do the merging of LIRC >> drivers to the kernel myself. In fact a lot of work still needs to be >> done before LIRC drivers are ready to be included into the kernel. > > [snip] > > On 02 Feb 2007 05:54:00 +0100, Christoph Bartelmus <lirc@bartelmus.de> wrote: >> Any help welcome. > > Here's a start. You really should run Lindent on the sources too.
Pekka, it would be better if you could sort out most of the basic issues with lirc directly with the developers of lirc and then prepare a complete patch series and post that to lkml. Incrementally adding one driver after another. Posting patches to non-existent sources to lkml is pointless. First create a discussion base, please.
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> > --- > > drivers/lirc_atiusb/lirc_atiusb.c | 102 ----------------- > drivers/lirc_bt829/lirc_bt829.c | 9 -
You might want to fix the directory structure first and check which drivers already exist in-tree. Also, as Vincent noted, most drivers have to be converted to use the input layer first.
Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |