Messages in this thread | | | Subject | Re: [PATCH] input: extend EV_LED | From | Richard Purdie <> | Date | Thu, 15 Feb 2007 23:36:04 +0000 |
| |
On Fri, 2007-02-16 at 00:24 +0100, Pavel Machek wrote: > > The led framework is generic. If you can write a function to turn it > > on/off you can drive it with the LED framework. > > Even if that function is slow and sleeps?
The LED class itself can call in interrupt context so you'd have to schedule a workqueue if you need to sleep.
> > One way I've come up with is adds capability to the class to have LED > > specific triggers and you can then expose these hardware capabilities as > > an extra trigger specific to the LED. > > > > Another proposal more specific to this use case was to have some > > information behind the scenes which the software timer based trigger > > could use to turn on the "hardware acceleration" if present and capable > > of the requested mode. This might just need a function pointer in the > > core so could be quite neat. > > I do not think we want to permit this led to run in "not accelerated" > mode. I believe i8042 accesses are pretty expensive.
Which means they probably won't work well with the standard triggers. Not something we can do much about though...
> > Nether patch exists yet. > > Yep, interested party should create one of them :-). (And I'd prefer > the first one, due to i8042 slowness).
Right, patches welcome :)
Cheers,
Richard
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |