Messages in this thread | | | Subject | Re: [PATCH 5/8] lguest: trivial guest network driver | From | Rusty Russell <> | Date | Thu, 15 Feb 2007 10:00:09 +1100 |
| |
On Thu, 2007-02-15 at 00:57 +1100, Herbert Xu wrote: > On Wed, Feb 14, 2007 at 03:47:55PM +1100, Rusty Russell wrote: > > > > It's also used to generate dma structs for outgoing packets. In that > > case, skb_headlen() == 0: > > I see, in that case you're guaranteed to have no fragments. > Still it feels a bit weird to have a length field that only > applies to the header part.
Indeed. In future if I want to create fragmented skbs for receive (large MTU support), I would actually set skb->len and skb->datalen and then could avoid the extra argument.
Cheers, Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |