| From | Andi Kleen <> | Subject | Re: [patch 7/9] Adapt the time initialization code | Date | Thu, 1 Feb 2007 12:26:33 +0100 |
| |
> +extern void time_initialize_cpu(void);
Never put externs into .c files. Multiple occurrences.
> +void time_initialize_cpu(void *info) > +{ > + unsigned long flags; > + int cpu = smp_processor_id();
Are you sure this can never preempt?
> + /* FIXME: what speed does the cpu really start at; I doubt cpu_khz is right at this point ??!!!
It should be. It comes from measurements. Unless the CPU changes frequency behind the kernel's back, but there is nothing that can be done then.
-Andio - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|