lkml.org 
[lkml]   [2007]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/10] x86_64: Use generic percpu
Date
On Friday 28 December 2007 01:10:51 travis@sgi.com wrote:
> x86_64 provides an optimized way to determine the local per cpu area
> offset through the pda and determines the base by accessing a remote
> pda.

And? The rationale for this patch seems to be incomplete.

As far as I can figure out you're replacing an optimized percpu
implementation which a dumber generic one. Which needs
at least some description why.

If the generic one is now as good or better than the
specific one that might be ok, but that should be somewhere
in the description.

Also for such changes .text size comparisons before/after
are a good idea.

-Andi



\
 
 \ /
  Last update: 2007-12-28 13:55    [W:2.140 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site