Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 05/10] x86_64: Use generic percpu | Date | Fri, 28 Dec 2007 13:54:51 +0100 |
| |
On Friday 28 December 2007 01:10:51 travis@sgi.com wrote: > x86_64 provides an optimized way to determine the local per cpu area > offset through the pda and determines the base by accessing a remote > pda.
And? The rationale for this patch seems to be incomplete.
As far as I can figure out you're replacing an optimized percpu implementation which a dumber generic one. Which needs at least some description why.
If the generic one is now as good or better than the specific one that might be ok, but that should be somewhere in the description.
Also for such changes .text size comparisons before/after are a good idea.
-Andi
| |