| Date | Thu, 27 Dec 2007 06:21:57 +0100 | From | Nick Piggin <> | Subject | Re: 2.6.24-rc6-mm1: __raw_spin_is_contended undefined |
| |
On Wed, Dec 26, 2007 at 09:21:58PM -0500, Joseph Fannin wrote: > On Sat, Dec 22, 2007 at 11:30:56PM -0800, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/ > > > > This doesn't build on powerpc with my .config: > > In file included from arch/powerpc/kernel/asm-offsets.c:17: > include/linux/sched.h: In function ???spin_needbreak???: > include/linux/sched.h:1947: error: implicit declaration of function ???__raw_spin_is_contended??? > > I don't see where __raw_spin_is_contended is defined for any arch > other than x86, so I guess this will happen on any non-x86 arch when > SMP=y and PREEMPT=y are set?
And CONFIG_GENERIC_LOCKBREAK is not defined, which is what powerpc needs.
Thanks for reporting, Nick
---
Index: linux-2.6/arch/powerpc/Kconfig =================================================================== --- linux-2.6.orig/arch/powerpc/Kconfig +++ linux-2.6/arch/powerpc/Kconfig @@ -53,6 +53,11 @@ config RWSEM_XCHGADD_ALGORITHM bool default y +config GENERIC_LOCKBREAK + bool + default y + depends on SMP && PREEMPT + config ARCH_HAS_ILOG2_U32 bool default y
|