lkml.org 
[lkml]   [2007]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] arch/x86: Use offsetof
Pavel Machek wrote:
>>
>> diff -u -p a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
>> --- a/arch/x86/kernel/vm86_32.c 2007-10-22 11:25:00.000000000 +0200
>> +++ b/arch/x86/kernel/vm86_32.c 2007-12-26 16:27:15.000000000 +0100
>> @@ -215,7 +215,9 @@ asmlinkage int sys_vm86old(struct pt_reg
>> ret = -EFAULT;
>> if (tmp)
>> goto out;
>> - memset(&info.vm86plus, 0, (int)&info.regs32 - (int)&info.vm86plus);
>> + memset(&info.vm86plus, 0,
>> + offsetof(struct kernel_vm86_struct, regs32) -
>> + offsetof(struct kernel_vm86_struct, vm86plus));
>
> I do not think this makes it more readable... (int) -> (char *) would
> make it portable and readable, AFAICT.
> Pavel

The right way to do it is:

memset(&info.vm86plus, 0, sizeof info.vm86plus);

-hpa


\
 
 \ /
  Last update: 2007-12-27 02:09    [W:0.036 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site