Messages in this thread | | | Date | Wed, 26 Dec 2007 20:19:13 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc. |
| |
On Wed, 26 Dec 2007, H. Peter Anvin wrote:
> Julia Lawall wrote: > > From: Julia Lawall <julia@diku.dk> > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > are more robust for comparing jiffies against other values. > > > > More robust, how? You already almost introduced a bug here...
I'm just summarizing the comment that goes with the definition of the time_after etc functions:
include/linux/jiffies.h:88 /* * These inlines deal with timer wrapping correctly. You are * strongly encouraged to use them * 1. Because people otherwise forget * 2. Because if the timer wrap changes in future you won't have to * alter your driver code. *
julia
| |