Messages in this thread | | | Date | Sat, 22 Dec 2007 23:37:33 -0800 | From | Pete Zaitcev <> | Subject | Re: [PATCH 4/4] usb: libusual: locking cleanup |
| |
On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker <dwalker@mvista.com> wrote:
> Then in usu_probe_thread() your basically stopping it at the start of > the function with a down(), and the up() is just ancillary .. So you > could easily move the up() further down in the function and still have > the same level of exclusion..
The unfortunate complication here is request_module. I didn't want to keep a semaphore locked across it, in case child waits for something. I wonder if there may be some deadlock that we cannot foresee. But I guess it won't hurt to try.
I tested the patch and it seems to work ok.
-- Pete
| |