Messages in this thread | | | Date | Mon, 24 Dec 2007 01:32:27 +0300 | From | Ivan Kokshaysky <> | Subject | Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue |
| |
On Sun, Dec 23, 2007 at 10:15:10PM +0100, Martin Mares wrote: > > - During that probe, you set a flag if any device has capabilities that > > extend beyond 0xff. > > Can this work? The extended capabilities are not linked to the normal > ones in any way.
Good point.
OTOH, we *do* have a flag for the extended capabilities - dev->cfg_size. Obviously, the pci probe *without* mmconfig will set it to 256 for *all* devices. So Linus' idea of enabling mmconfig per-device makes a lot of sense in the end - if mmconfig works, it just sets dev->cfg_size to 4096. Without bloating the struct pci_dev or screwing up innocent arches...
Ivan.
| |