Messages in this thread | | | Date | Fri, 21 Dec 2007 10:33:26 +0000 | From | Alan Cox <> | Subject | Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi_cmnd |
| |
On Fri, 21 Dec 2007 13:30:08 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly > by some low level drivers (that typically happens with USB mass > storage).
Should that not be fixed in USB storage by using pci_alloc_coherent on the PCI device of the hub not peeing directly into kernel space ?
It's also incomplete as a fix because I don't see what guarantees the buffer size will always exceed cache line size
Alan
| |