Messages in this thread | | | Date | Thu, 20 Dec 2007 14:34:18 -0800 | From | Randy Dunlap <> | Subject | Re: Trailing periods in kernel messages |
| |
On Thu, 20 Dec 2007 14:19:28 -0800 Andrew Morton wrote:
> On Thu, 20 Dec 2007 21:54:11 +0000 > Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > > > Documentation/Coding Style > > > > > > Chapter 13: Printing kernel messages > > > > > > Kernel messages do not have to be terminated with a period. > > > > > > This piece of the document is wrong. It should also be changed. I've no > > idea how such a ludicrous statement ever got into the Coding Style but I > > have never seen it discussed and an archive search suggests it just > > sneaked in without any kind of approval and discussion the list. > > > > Kernel messages are in English. Let us keep it that way. Missing > > punctuation is equated by many parts of the English speaking world with > > poor quality, sloppy products and low levels of education. These are not > > things with which we wish to be associated IMHO. > > > > NAK to the patch. > > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' . | wc -l > 105297 > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' . | wc -l > 12743 > > For the record, I won't be taking any "add period to printk" patches.
IMO if checkpatch contains a check for trailing periods, it should only be part of the strict/pedantic checks. But it's not needed.
> akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' net | wc -l > 4978 > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' net | wc -l > 493 > > Send 'em to Dave!
--- ~Randy
| |