lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: not needed patch
Ingo Molnar wrote:
> * Mike Travis <travis@sgi.com> wrote:
>
>>>> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could
>>>> use c->cpu_index in identify_cpu.
>>> but that's 2.6.25 stuff, right? Travis?
>>>
>> Looking at this more closely, yes my change is not needed and should
>> be removed. I'm not sure what caused my cpu # to be all zeros when I
>> was testing, but it now works ok without my change.
>
> how about this question:
>
>>> well, it might in the worst-case be a superfluous change, but not
>>> cause any problems in 2.6.24, right?
>
> Ingo

I don't think it hurts anything except as noted, it wouldn't be available
to the subfunctions (like identify_cpu) that might need the cpu_index
(which also is noted that none currently do.)

-Mike



\
 
 \ /
  Last update: 2007-12-20 17:57    [W:0.035 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site