Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 0/5] sg_ring for scsi | Date | Thu, 20 Dec 2007 18:53:48 +1100 |
| |
On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: > On Thu, 20 Dec 2007 16:45:18 +1100 > > Rusty Russell <rusty@rustcorp.com.au> wrote: > > OK, some fixes since last time, as I wade through more SCSI drivers. > > Some drivers use "use_sg" as a flag to know whether the request_buffer is > > a scatterlist: I don't need the counter, but I still need the flag, so I > > fixed that in a more intuitive way (an explicit ->sg pointer in the cmd). > > use_sg and the request_buffer will be removed shortly. > > http://marc.info/?l=linux-scsi&m=119754650614813&w=2
Thanks! Is there a git tree somewhere with these changes?
> I think that we tried the similar idea before, scsi_sgtable, but we > seem to settle in the current simple approach.
Yes, a scsi-specific solution is a bad idea: other people use sg. Manipulating the magic chains is horrible; it looks simple to the places which simply want to iterate through it, but it's awful for code which wants to create them.
Cheers, Rusty.
| |