Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v4 7/8] debugfs: allow access to signed values | Date | Thu, 20 Dec 2007 13:47:13 +0100 |
| |
On Thursday 20 December 2007, Stefano Brivio wrote: > debugfs: allow access to signed values > > Add debugfs_create_s{8,16,32,64}. For these to work properly, we need to remove > a cast in libfs, change the simple_attr_open prototype and thus fix the users as > well. > > Cc: Johannes Berg <johannes@sipsolutions.net> > Cc: Mattias Nissler <mattias.nissler@gmx.de> > To: Greg Kroah-Hartman <gregkh@suse.de> > To: Arnd Bergmann <arndb@de.ibm.com> > To: Akinobu Mita <akinobu.mita@gmail.com> > Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Have you checked that spufs still builds? I would guess that you need to do the same interface changes there.
Also, Christoph has recently posted a suggestion for how to improve the interface to allow the 'get' operation to return an error: http://patchwork.ozlabs.org/cbe-oss-dev/patch?id=14962
I'd suggest consolidating the two changes in order to avoid merge conflicts.
Arnd <><
| |