Messages in this thread | | | Subject | Re: [PATCH] Declare PNP option parsing functions as __init | From | Thomas Renninger <> | Date | Sun, 02 Dec 2007 14:34:56 +0100 |
| |
On Sat, 2007-12-01 at 01:33 +0100, Rene Herman wrote: > On 01-12-07 00:52, Bjorn Helgaas wrote: > > > On Friday 30 November 2007 04:37:26 pm Rene Herman wrote: > >> On 30-11-07 18:04, Thomas Renninger wrote: > >>> If I have not overseen something, it should be rather obvious that those > >>> can all be declared __init... > >>> --------------- > >>> > >>> Declare PNP option parsing functions as __init > >>> > >>> There are three kind of parse functions provided by PNP acpi/bios: > >>> - get current resources > >>> - set resources > >>> - get possible resources > >>> The first two may be needed later at runtime. > >>> The possible resource settings should never change dynamically. > >>> And even if this would make any sense (I doubt it), the current implementation > >>> only parses possible resource settings at early init time: > >>> -> declare all the option parsing __init > >>> > >>> Signed-off-by: Thomas Renninger <trenn@suse.de> > >> Yes. Obviousness aside, > >> > >> (0) pnpacpi_add_device is only caller of > >> ... > > > > I agree this is probably safe in the current implementation. > > > > However, I think the current implementation is just broken because > > we can't really handle hotplug of ACPI devices. Specifically, I think > > the first TBD in acpi_bus_check_device() should be fleshed out so it > > does something like pnpacpi_add_device(). > > > > So my dissenting opinion is that this patch would just get reverted > > soon anyway when somebody finishes implementing ACPI hotplug, and > > therefore it's not worth doing. > > <shrug> > > The PnPBIOS bits should still be fine at least I guess. And, it would seem > this is rather essential to Thomas' efforts of making this stuff dynamic in > the first place anyway. No it is not. It is just another optimization I saw while going through these code parts...
Thomas
| |